Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Message): fix return type for reply #6720

Merged
merged 1 commit into from
Oct 2, 2021
Merged

docs(Message): fix return type for reply #6720

merged 1 commit into from
Oct 2, 2021

Conversation

cherryblossom000
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Fixes the return type of Message#reply from Promise<Message | Message[]> to Promise<Message>.

Due to #5918 Message#reply can no longer return an array of messages, which is also reflected in the TypeScript typings.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@cherryblossom000
docs(Message): fix return type for reply
93acc69 
Due to #5918 `Message#reply` can no longer return an array of messages, which is reflected in [the TypeScript typings][1].

[1]: https://github.com/discordjs/discord.js/blob/fe9500538e76423e49e16a1e1756eb04b5f40531/typings/index.d.ts#L1252
vladfrangu
vladfrangu approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the types are also correct! If they are, LGTM

@cherryblossom000
Copy link
Contributor Author

cherryblossom000 commented Sep 30, 2021 •
edited
Loading

@vladfrangu Yep, the typings are already correct (which I also linked in the PR description).

@iCrawl iCrawl merged commit 3f11009 into discordjs:main Oct 2, 2021
@iCrawl iCrawl added this to the Version 13.2 milestone Oct 2, 2021
@cherryblossom000 cherryblossom000 deleted the patch-1 branch October 2, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.
5 participants
@cherryblossom000 @vladfrangu @iCrawl @kyranet @SpaceEEC